[Webkit-unassigned] [Bug 110193] OpenCL implementation of FEMerge filter.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110193


Zoltan Herczeg <zherczeg at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189262|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Zoltan Herczeg <zherczeg at webkit.org>  2013-02-20 01:46:27 PST ---
(From update of attachment 189262)
Few more comments:

View in context: https://bugs.webkit.org/attachment.cgi?id=189262&action=review

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEMerge.cpp:39
> +__kernel void copy(__write_only image2d_t destination, __read_only image2d_t source, int x, int y, int width, int height)

width, height is unused argument.

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEMerge.cpp:77
> +inline void FilterContextOpenCL::applyFEMergeCopy(OpenCLHandle destination, IntSize destinationSize, OpenCLHandle source, IntRect relativeSourceRect)

Use references such as IntSize&

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEMerge.cpp:85
> +    kernel.addArgument(relativeSourceRect.width());
> +    kernel.addArgument(relativeSourceRect.height());

Ditto.

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEMerge.cpp:124
> +        IntRect relativeSourceRect(in->absolutePaintRect());

use IntPoint when possible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.