[Webkit-unassigned] [Bug 105463] [Feature] Implement pointer events
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 19 22:47:02 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=105463
--- Comment #9 from WebKit Review Bot <webkit.review.bot at gmail.com> 2013-02-19 22:49:22 PST ---
Attachment 189248 did not pass style-queue:
Source/WebCore/html/HTMLElement.cpp:341: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.idl:32: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/platform/PlatformPointerEvent.h:36: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4]
Source/WebCore/platform/PlatformPointerEvent.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/platform/PlatformPointerEvent.h:53: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:54: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:55: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:56: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:57: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:58: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:59: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:71: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:77: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:82: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.h:114: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/platform/PlatformPointerEvent.h:128: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/dom/PointerEvent.h:40: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/dom/PointerEvent.h:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.h:104: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:105: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:106: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:107: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:108: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.h:109: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:110: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:111: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:112: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:115: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:118: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:119: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:120: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:121: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:122: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.h:123: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:124: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:123: The parameter name "clipboard" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/dom/PointerEvent.h:125: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.h:126: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.h:153: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/platform/PlatformPointerEvent.cpp:33: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/WebCore/platform/PlatformPointerEvent.cpp:56: An else should appear on the same line as the preceding } [whitespace/newline] [4]
Source/WebCore/platform/PlatformPointerEvent.cpp:58: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/platform/PlatformPointerEvent.cpp:60: An else should appear on the same line as the preceding } [whitespace/newline] [4]
Source/WebCore/platform/PlatformPointerEvent.cpp:70: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/PlatformPointerEvent.cpp:80: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/platform/PlatformPointerEvent.cpp:111: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/platform/PlatformPointerEvent.cpp:141: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/platform/PlatformPointerEvent.cpp:151: Missing space before ( in switch( [whitespace/parens] [5]
Source/WebCore/platform/PlatformPointerEvent.cpp:175: Missing space before ( in switch( [whitespace/parens] [5]
Source/WebCore/platform/PlatformPointerEvent.cpp:194: Should have a space between // and comment [whitespace/comments] [4]
Source/WebCore/platform/PlatformPointerEvent.cpp:195: Should have a space between // and comment [whitespace/comments] [4]
Source/WebCore/platform/PlatformPointerEvent.cpp:196: Should have a space between // and comment [whitespace/comments] [4]
Source/WebCore/platform/PlatformPointerEvent.cpp:197: Should have a space between // and comment [whitespace/comments] [4]
Source/WebCore/platform/PlatformPointerEvent.cpp:198: Should have a space between // and comment [whitespace/comments] [4]
Source/WebCore/dom/PointerEvent.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/WebCore/dom/PointerEvent.cpp:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/WebCore/dom/PointerEvent.cpp:58: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/dom/PointerEvent.cpp:59: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/dom/PointerEvent.cpp:68: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:69: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:70: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:71: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:72: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.cpp:73: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:74: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:75: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:76: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:79: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:82: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:83: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:84: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:85: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:86: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.cpp:87: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:88: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:89: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.cpp:90: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:91: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:92: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:93: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:94: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:95: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:96: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.cpp:97: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:98: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:99: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:100: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:103: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:106: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:107: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:108: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:109: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:110: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.cpp:111: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:112: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:113: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebCore/dom/PointerEvent.cpp:130: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.cpp:143: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/dom/PointerEvent.cpp:161: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/dom/PointerEvent.cpp:164: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/dom/PointerEvent.cpp:167: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/dom/PointerEvent.cpp:174: Missing space before ( in switch( [whitespace/parens] [5]
Source/WebCore/dom/PointerEvent.cpp:175: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/dom/PointerEvent.cpp:223: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/dom/PointerEvent.cpp:224: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/page/EventHandler.cpp:4050: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/page/EventHandler.cpp:4057: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/page/EventHandler.cpp:4121: Declaration has space between type name and * in Node *nodeUnderPointer [whitespace/declaration] [3]
Source/WebCore/page/EventHandler.cpp:4122: Declaration has space between type name and * in Node *lastNodFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/Document.idl', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/Element.idl', u'Source/WebCore/dom/EventNames.h', u'Source/WebCore/dom/EventNames.in', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/PointerEvent.cpp', u'Source/WebCore/dom/PointerEvent.h', u'Source/WebCore/dom/PointerEvent.idl', u'Source/WebCore/html/HTMLAttributeNames.in', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DOMWindow.idl', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/EventHandler.h', u'Source/WebCore/platform/PlatformEvent.h', u'Source/WebCore/platform/PlatformPointerEvent.cpp', u'Source/WebCore/platform/PlatformPointerEvent.h', u'Source/WebKit/chromium/features.gypi']" exit_code: 1
eUnderPointer [whitespace/declaration] [3]
Source/WebCore/page/EventHandler.cpp:4126: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/page/EventHandler.cpp:4177: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 111 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list