[Webkit-unassigned] [Bug 110240] webkit-patch rebaseline-expectations incorrectly rebaselines calendar-picker test results

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110240





--- Comment #4 from Dirk Pranke <dpranke at chromium.org>  2013-02-19 15:20:21 PST ---
(In reply to comment #3)
> Created an attachment (id=189175)
 --> (https://bugs.webkit.org/attachment.cgi?id=189175&action=review) [details]
> stderr from rebaseline-expectations
> 
> I still think there's also a bug somewhere with rebaseline-expectations.  If I try to rebaseline all or one of the calendar-picker tests from that flakiness dashboard link (with and without r142941 reverted) it just removes the Rebaseline lines but updates no images, e.g. a line like this:
> 
> webkit.org/b/110240 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html [ Rebaseline ]
> 
> (As for the tests not really passing post-rebaseline, maybe they're all just flaky and they've been failing for so long it wasn't obvious?)

Ah, I think you need to put either "[ Rebaseline Failure ]" or "[ Rebaseline ImageOnlyFailure ]" so that the tool knows which type of failures to try and rebaseline. I think "[ Rebaseline ]" is equivalent to "[ Rebaseline Skip ]".

This could probably be improved :).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.