[Webkit-unassigned] [Bug 109980] [WK2] Calls to WKPageLoadURL() when WebProcess was terminated may fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109980


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189135|review?                     |review+
               Flag|                            |




--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2013-02-19 13:28:45 PST ---
(From update of attachment 189135)
View in context: https://bugs.webkit.org/attachment.cgi?id=189135&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:92
> +// First test will load a blank page and next kill WebProcess, the expected
> +// result is that a call to page load should spawn a new WebProcess.

You should say "This test" instead of "First test".
Rationale:
-If someone add a test in this file, the comments get out of date.
-We should not imply there is an order of testing. Testing the test in any order should be the same.

> Tools/TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:103
> +// Crash handler, used only by the second test.

"the second test" -> LoadPageInCrashHandler

> Tools/TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:108
> +    // In the second test, we try to load from the crash handler.

ditto.

> Tools/TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:113
> +// This is similar to the first test (i.e. we will load a page and

"the first test"->LoadPageAfterCrash

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.