[Webkit-unassigned] [Bug 109972] IDB Cursor continue moves one item at a time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109972





--- Comment #3 from Joshua Bell <jsbell at chromium.org>  2013-02-19 12:54:41 PST ---
(From update of attachment 188643)
View in context: https://bugs.webkit.org/attachment.cgi?id=188643&action=review

> Source/WebCore/ChangeLog:13
> +        optimization.

Include your performance numbers, even if it's a manual A/B test. I think you had a case where the cost of ~700 continues went from ~500ms to ~80ms ?

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1273
> +    bool firstIteration = true;

It looks like a follow-up patch could potentially simplify firstSeek()/IteratorState/firstIteration a bit, but I think this is good for now.

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1284
> +            if (firstIteration && key && forward) {

Maybe add FIXME comment to optimize key seeking for reverse cursors?

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1414
> +        return ObjectStoreDataKey::encode(

No line wrap here.

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1476
> +        return ObjectStoreDataKey::encode(

No line wrap here.

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1546
> +        return IndexDataKey::encode(

No line wrap here.

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1638
> +        return IndexDataKey::encode(

No line wrap here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.