[Webkit-unassigned] [Bug 109674] start and stop attributes in AudioBufferSourceNode should include "raises (exception)" in IDL files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109674





--- Comment #14 from Chris Rogers <crogers at google.com>  2013-02-19 12:06:04 PST ---
(From update of attachment 188470)
View in context: https://bugs.webkit.org/attachment.cgi?id=188470&action=review

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:150
> +    if (!(m_playbackState == SCHEDULED_STATE || m_playbackState == PLAYING_STATE)) {

I think it's better to be less restrictive here and instead check:

if (m_playbackState == UNSCHEDULED_STATE)

Because in some cases it's possible for the source to reach the FINISHED_STATE by itself and we don't want an exception thrown.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.