[Webkit-unassigned] [Bug 110206] [v8] ScriptValue has dangerous copy semantics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110206


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189072|review?                     |review+
               Flag|                            |




--- Comment #9 from Kentaro Hara <haraken at chromium.org>  2013-02-19 09:19:21 PST ---
(From update of attachment 189072)
View in context: https://bugs.webkit.org/attachment.cgi?id=189072&action=review

Understood. Let's kill v8ValueRaw() in a follow-up.

> Source/WebCore/ChangeLog:9
> +        Update ScriptValue to use a reference counted ScopedPersistent
> +        as the existing implementation makes it easy to return dead references.

Update the ChangeLog.

> Source/WebCore/bindings/v8/ScriptValue.h:138
> +    v8::Handle<v8::Value> v8ValueRaw() const

Please add FIXME to indicate that v8ValueRaw() should be deprecated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.