[Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109422





--- Comment #23 from Benjamin Dupont <bdupont at nds.com>  2013-02-19 06:23:35 PST ---
(In reply to comment #20)
> (From update of attachment 189060 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189060&action=review
> 
> > Source/WebKit/qt/WidgetApi/qgraphicswebview.cpp:412
> > +            if (scene()->isActive())
> 
> Mhh, this feels a bit flimsy.
> Don't we risk missing our opportunity to set the proper page visibility later on if the scene is activated ?
I must check what's happenning if a scene is activated and we add a QGraphicsWebView hidden.

> 
> > Source/WebKit/qt/WidgetApi/qgraphicswebview.cpp:413
> > +                d->page->setVisibilityState(WebCore::PageVisibilityStateVisible, false);
> 
> and WebCore enum use here...
> 
> > Source/WebKit/qt/WidgetApi/qgraphicswebview.cpp:415
> > +            d->page->setVisibilityState(WebCore::PageVisibilityStateHidden, false);
> 
> and here.
Why can't I use WebCore::PageVisibilityState enum here? Is it better to use a 'int' value?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.