[Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 05:50:42 PST 2013


--- Comment #20 from Pierre Rossi <pierre.rossi at gmail.com>  2013-02-19 05:53:04 PST ---
(From update of attachment 189060)
View in context: https://bugs.webkit.org/attachment.cgi?id=189060&action=review

> Source/WebKit/qt/WidgetApi/qgraphicswebview.cpp:412
> +            if (scene()->isActive())

Mhh, this feels a bit flimsy.
Don't we risk missing our opportunity to set the proper page visibility later on if the scene is activated ?

> Source/WebKit/qt/WidgetApi/qgraphicswebview.cpp:413
> +                d->page->setVisibilityState(WebCore::PageVisibilityStateVisible, false);

and WebCore enum use here...

> Source/WebKit/qt/WidgetApi/qgraphicswebview.cpp:415
> +            d->page->setVisibilityState(WebCore::PageVisibilityStateHidden, false);

and here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list