[Webkit-unassigned] [Bug 105527] [Web Inspector]Add WebSocket networking events in WebInspector Timeline panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105527





--- Comment #13 from pdeng6 <pan.deng at intel.com>  2013-02-18 23:57:01 PST ---
(In reply to comment #9)
> (From update of attachment 188853 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188853&action=review
> 
> > Source/WebCore/inspector/TimelineRecordFactory.cpp:211
> > +PassRefPtr<InspectorObject> TimelineRecordFactory::createWebSocketCreateData(unsigned long identifier, const KURL& url, const String& protocol)
> 
> Since these are only used once, you can inline them.
> 
Done, thanks.
> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:376
> > +            return this._sendRequestRecords[record.data["identifier"]];
> 
> I am not sure we want to glue web socket records. I'd rather not.
> 
> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:677
> > +        presentationModel._sendRequestRecords[record.data["identifier"]] = this;
> 
> No glueing required, drop this.
> 
new record types of websocket are not handled in _findParentRecord this time, so websocket record won't be glued.
I save create websocket record here to keep the websocket URL for following events, I think websocket URL is useful for multiple websocket case (show them in PopupContent).

> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:683
> > +        var webSocketCreateRecord = presentationModel._sendRequestRecords[record.data["identifier"]];
> 
> ditto
> 
> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:952
> > +                    contentHelper._appendTextRow(WebInspector.UIString("URL"), this.webSocketURL);
> 
> Strings should be a part of localizedStrings.js (under WebCore/English.lproj)
Done.
I will prepare a test.
Thanks for your review.

Pan

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.