[Webkit-unassigned] [Bug 105527] [Web Inspector]Add WebSocket networking events in WebInspector Timeline panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105527


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188853|review?                     |review-
               Flag|                            |




--- Comment #9 from Pavel Feldman <pfeldman at chromium.org>  2013-02-18 05:17:02 PST ---
(From update of attachment 188853)
View in context: https://bugs.webkit.org/attachment.cgi?id=188853&action=review

> Source/WebCore/inspector/TimelineRecordFactory.cpp:211
> +PassRefPtr<InspectorObject> TimelineRecordFactory::createWebSocketCreateData(unsigned long identifier, const KURL& url, const String& protocol)

Since these are only used once, you can inline them.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:376
> +            return this._sendRequestRecords[record.data["identifier"]];

I am not sure we want to glue web socket records. I'd rather not.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:677
> +        presentationModel._sendRequestRecords[record.data["identifier"]] = this;

No glueing required, drop this.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:683
> +        var webSocketCreateRecord = presentationModel._sendRequestRecords[record.data["identifier"]];

ditto

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:952
> +                    contentHelper._appendTextRow(WebInspector.UIString("URL"), this.webSocketURL);

Strings should be a part of localizedStrings.js (under WebCore/English.lproj)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.