[Webkit-unassigned] [Bug 109560] Implement coordinated scrollbar for subframes and sublayers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109560





--- Comment #23 from Sami Kyöstilä <skyostil at chromium.org>  2013-02-18 03:57:21 PST ---
(From update of attachment 188658)
Thanks for adding the test. I think this looks good modulo Antonio's comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=188658&action=review

> Source/WebCore/platform/ScrollableArea.h:205
> +    friend class ScrollingCoordinator;

Could you move this next to the accessor methods so the association is clearer -- like we do for ScrollAnimator below. I can't help but wonder whether we should instead make the accessors public instead, but maybe there's a good reason for keeping them protected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.