[Webkit-unassigned] [Bug 105126] Flexbox should ignore firstLetter pseudo element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105126





--- Comment #9 from huangxueqing <huangxueqing at baidu.com>  2013-02-17 18:41:29 PST ---
(In reply to comment #8)
> (From update of attachment 179648 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179648&action=review
> 
> Can you double check the results of the form pseudo element tests?  It looks like the checked in results don't currently apply style to the form controls.
> 
Form input controls actually layout with flexbox since browser css defined in  WebCore/css/html.css as:
input[type="date"|"datetime"|"datatime-local"|"month"|"time"|"week"] {
    ... ...
    display: -webkit-inline-flex;
    ... ...
}

> Also, I would probably merge your new tests into a single reftest.  No need to create lots of separate test files.
> 
OK

> > Source/WebCore/rendering/RenderBlock.cpp:6466
> > +    if (isFlexibleBox())
> > +        return;
> 
> This looks funny. Do we create the first letter renderer?
This code just prevent RenderBlock update its first text child. No, the first letter renderer would not be created. The first letter renderer as the first text child's new parent used to update RenderText's first letter info.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.