[Webkit-unassigned] [Bug 109135] Web Inspector: Sort by Initiator functionality of Network Panel doesn't work well

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109135





--- Comment #5 from pdeng6 <pan.deng at intel.com>  2013-02-16 18:59:25 PST ---
(In reply to comment #2)
> (From update of attachment 186991 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186991&action=review
> 
> > Source/WebCore/inspector/front-end/NetworkPanel.js:2220
> > +    get displayedInitiatorUrl()
> 
> We're not using getters/setters in new code.
Got it, done, thanks!
> 
> > Source/WebCore/inspector/front-end/NetworkPanel.js:2226
> > +        return displayedUrl.replace(/:\d*$/, "");
> 
> Accessing text content and using regexp should be avoided at all and specifically in loop (sorting).
> This data should be stored in node field when refresh comes.
> 
Done, thanks.
> > Source/WebCore/inspector/front-end/NetworkPanel.js:2235
> > +        return displayedUrl.replace(/[^:]*:/g, "");
> 
> Ditto.
> 
> > Source/WebCore/inspector/front-end/NetworkPanel.js:2407
> > +    if (!a._request.initiator || a._request.initiator.type === "other")
> 
> Enum containing ["parser", "script", "other"] should be declared and used to avoid further typos.
> IMHO it could be placed in NetworkRequest.js
Great, done, thanks :)

Pan

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.