[Webkit-unassigned] [Bug 109926] Fix build when css3-conditional-rules feature flag is enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 15 16:14:08 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109926





--- Comment #15 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-02-15 16:16:24 PST ---
(In reply to comment #14)
> (From update of attachment 188657 [details])
> See comment #9.
> 
> Please stop spamming this bug with patches without addressing earlier review comments.

Sorry, I did not see your comments here since I was talking to the guys on irc. This problem only happens if css3-conditional-rules is enabled (see DOMWindowCSS.h) and that feature flag is not enabled by default in any buildbot. I usually use a patch to enable that feature flag before sending my patches with css3 code to buildbots so they do really test the patch [1]. Without such a trick the bots just give a green for the patch when it in fact did not test the patch.

[1] https://bugs.webkit.org/show_bug.cgi?id=106819#c7

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list