[Webkit-unassigned] [Bug 109926] Fix build when css3-conditional-rules feature flag is enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 15 07:47:54 PST 2013


--- Comment #5 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-02-15 07:50:12 PST ---
(In reply to comment #4)
> (From update of attachment 188544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188544&action=review
> > Source/WebCore/ChangeLog:9
> > +        05ccd1f76464bc0adc15d7fc256078bd497271c5 if css3-conditional-rules is
> Use SVN revision (i.e. r12345) instead of git hash.

Ok, I will update the patch.

> > Source/WebCore/css/DOMWindowCSS.h:43
> > +    virtual ~DOMWindowCSS() { }
> I don't see why the default destructor is not enough. AFAIK no other class is inheriting from this one.

The problem is that Source/WebCore/bindings/scripts/CodeGeneratorV8.pm generates code that tries to access DOMWindowCSS's vtable, which does not seem to be created unless there is at least one virtual method in the class.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list