[Webkit-unassigned] [Bug 109674] start and stop attributes in AudioBufferSourceNode should include "raises (exception)" in IDL files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109674


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188470|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from Kentaro Hara <haraken at chromium.org>  2013-02-14 20:36:47 PST ---
(From update of attachment 188470)
View in context: https://bugs.webkit.org/attachment.cgi?id=188470&action=review

> LayoutTests/webaudio/audiobuffersource-note.html:12
> +<div id="description"></div>
> +<div id="console"></div>

Nit: They are not needed.

> LayoutTests/webaudio/audiobuffersource-note.html:19
> +        testRunner.dumpAsText();

Nit: This is not needed.

> LayoutTests/webaudio/audiobuffersource-note.html:23
> +        testRunner.waitUntilDone();
> +    }
> +
> +    window.jsTestIsAsync = true;

This test needs not to be async.

> LayoutTests/webaudio/audiobuffersource-note.html:37
> +    try {
> +        bufferSource.start(0);
> +        buffersource.stop(0.5);
> +        buffersource.stop(0.8);
> +        testFailed("Exception should be thrown if stop is called twice.");
> +    } catch(e) {
> +        testPassed("Exception been thrown as stop is called twice.");
> +    }

You can use shouldThrow() in js-test-pre.js.

> LayoutTests/webaudio/audiobuffersource-note.html:45
> +    try {
> +        buffersource.start(0);
> +        buffersource.start(0);
> +        testFailed("Exception should be thrown if start is called twice.");
> +    } catch(e) {
> +        testPassed("Exception been thrown as start is called twice.");
> +    }

Ditto.

> LayoutTests/webaudio/audiobuffersource-note.html:52
> +    try {
> +        buffersource.stop(0);
> +        testFailed("Exception should be thrown if stop is called before start.");
> +    } catch(e) {
> +        testPassed("Exception been thrown as stop is called before start.");
> +    }

Ditto.

> LayoutTests/webaudio/audiobuffersource-note.html:54
> +    finishJSTest();

Remove this. This test needs not to be async.

> LayoutTests/webaudio/audiobuffersource-note.html:57
> +runTest();

Nit: You can directly write test cases here instead of calling runTest().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.