[Webkit-unassigned] [Bug 109874] Update FeatureObserver on top level navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109874


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188448|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2013-02-14 16:36:34 PST ---
(From update of attachment 188448)
View in context: https://bugs.webkit.org/attachment.cgi?id=188448&action=review

> Source/WebCore/loader/FrameLoader.cpp:3272
> +        m_frame->page()->setFeatureObserver(adoptPtr(reinterpret_cast<FeatureObserver*>(0)));

You can write:

m_frame->page()->setFeatureObserver(nullptr)

which is a bit cleaner.

> Source/WebCore/page/FeatureObserver.cpp:45
> +    HistogramSupport::histogramEnumeration("WebCore.FeatureObserver.TrackingStats", PageVisits, NumberOfStatistics);

I'd prefer to use the same histogram for the baseline stats as for the other stats.  That makes sure they stay in sync.

> Source/WebCore/page/FeatureObserver.cpp:66
> +    if (!page->featureObserver())
> +        page->setFeatureObserver(adoptPtr(new FeatureObserver()));

Rather than calling "new" and "delete" all the time, we can just trigger measurement on navigation and reset the m_featureBits.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.