[Webkit-unassigned] [Bug 103259] Numeric identifiers of events are not guaranteed to be unique

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103259


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176889|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #13 from Alexey Proskuryakov <ap at webkit.org>  2013-02-14 11:56:15 PST ---
(From update of attachment 176889)
View in context: https://bugs.webkit.org/attachment.cgi?id=176889&action=review

> Source/WebCore/Modules/geolocation/Geolocation.cpp:318
> +    } while (UNLIKELY(!m_watchers.add(watchID, notifier)));

Please don't put this UNLIKELY here. It's not hot code, and there is no need to add visual noise to it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.