[Webkit-unassigned] [Bug 109781] Rename some files in WebCore/editing/

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 14 10:27:50 PST 2013


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com

--- Comment #1 from Ryosuke Niwa <rniwa at webkit.org>  2013-02-14 10:30:06 PST ---
(In reply to comment #0)
> htmlediting.{cpp,h}   -> EditorCommandHelper.{cpp,h}

I'd prefer calling it EditingHelper.{cpp/h} or EditorHelper.{cpp/h} since there are functions in that file used outside of editor commands.

> markup.{cpp,h}        -> MarkupHelper.{cpp,h}

Sounds good. Can we split StylizedMarkupAccumulator into its own file too?

> visible_units.{cpp,h} -> VisiblePositionHelper.{cpp,h}

I'd prefer VisibleUnits.{cpp/h} instead since line, paragraph, etc... are visible units.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list