[Webkit-unassigned] [Bug 108892] Passing alpha to DeferredImageDecoder once decoding completes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108892


Stephen White <senorblanco at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188163|review?                     |review+
               Flag|                            |




--- Comment #15 from Stephen White <senorblanco at chromium.org>  2013-02-13 17:03:00 PST ---
(From update of attachment 188163)
View in context: https://bugs.webkit.org/attachment.cgi?id=188163&action=review

OK.  r=me

> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:227
> +    MutexLocker lock(m_alphaMutex);
> +    return m_hasAlpha;

I know I'll regret asking this, since threading has a long history of making me look like an idiot, but why do you need to lock the mutex for a read?  It's a bool, so all reads should be atomic anyway, no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.