[Webkit-unassigned] [Bug 109765] Reschedule shared CFRunLoopTimer instead of reconstructing it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109765


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188213|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-02-13 16:38:21 PST ---
(From update of attachment 188213)
View in context: https://bugs.webkit.org/attachment.cgi?id=188213&action=review

Hilarious! r+ from me since this looks like correct use of the API to me, though you might wanna double-check with someone with more CF knowledge.

> Source/WebCore/platform/mac/SharedTimerMac.mm:154
> +    static CFRunLoopTimerRef timer;
> +    if (!timer) {

You could use dispatch_once() for this block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.