[Webkit-unassigned] [Bug 108892] Passing alpha to DeferredImageDecoder once decoding completes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108892





--- Comment #12 from Min Qin <qinmin at chromium.org>  2013-02-13 13:26:25 PST ---
(From update of attachment 187898)
View in context: https://bugs.webkit.org/attachment.cgi?id=187898&action=review

>> Source/WebCore/platform/graphics/chromium/DeferredImageDecoder.cpp:186
>> +        return pixelRef->frameGenerator()->hasAlpha();
> 
> DeferredImageDecoder already has a pointer to ImageFrameGenerator.

Done.

>> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.h:70
>> +    bool hasAlpha() const { return m_hasAlpha; }
> 
> This is not thread-safe and we need a lock for reading and writing to this value.
> 
> You don't want to acquire the decodeMutex.. so I guess it's fine to have a alphaMutex (reluctantly..)

Good catch on thread safety.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.