[Webkit-unassigned] [Bug 108892] Passing alpha to DeferredImageDecoder once decoding completes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108892





--- Comment #5 from Hin-Chung Lam <hclam at google.com>  2013-02-12 09:55:39 PST ---
(From update of attachment 186672)
View in context: https://bugs.webkit.org/attachment.cgi?id=186672&action=review

>>> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:213
>>> +    bool hasAlpha = (*decoder)->frameHasAlphaAtIndex(0);
>> 
>> Do something like:
>> 
>> m_hasAlpha = isComplete && !fullSizeBitmap.isOpaque();
> 
> hmm.... if isComplete is false, shouldn't we return true there to force image decoding?

I don't know what you mean.

Actually now I think about it again you can just do !fullSizeBitmap.isOpaque(). Don't call frameHasAlphaAtIndex(0) it might have side effect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.