[Webkit-unassigned] [Bug 109488] Web Inspector: fix closure compilation warnings caused by setVariableValue change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 03:45:30 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109488





--- Comment #7 from Peter Rybin <prybin at chromium.org>  2013-02-12 03:47:43 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 187676 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=187676&action=review
> > 
> > >> Source/WebCore/inspector/Inspector.json:2936
> > >> +                    { "name": "newValue", "$ref": "Runtime.CallArgument", "description": "New variable value." },
> > > 
> > > Can you provide a test for this command?
> > 
> > I thought LayoutTests/inspector-protocol/debugger-setVariableValue.html was that test.
> 
> Oh, I see. I meant that it would be nice if we had a test that would require changes in accord with your concern https://bugs.webkit.org/show_bug.cgi?id=109488#c2

That's right. But so far we don't any client that depends on parameter order. I don't think we should prepare such client only to prove that parameter order in fact changed.

However, I wonder if we should change parameter order. For example Java project bindings depends on order and theoretically such changes might go unnoticed unless caught by parameter type checks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list