[Webkit-unassigned] [Bug 105260] table-caption stride over pages.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105260





--- Comment #5 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2013-02-12 02:26:16 PST ---
Thank you for reviewing.

I change the code, because I think this code is better than the old one.

(In reply to comment #3)
> (From update of attachment 179889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179889&action=review
> 
> The change is probably good, I just have a hard time understanding the justification.
> 
> > Source/WebCore/ChangeLog:10
> > +        Fix table-caption stride over pages.
> > +        RenderBlock::adjustLinePositionForPagination() don't adjust 1st line inside table-caption.
> > +        Make adjustLinePositionForPagination() adjust 1st line inside table-caption.
> 
> This ChangeLog is very imprecise and doesn't describe *why* it's correct / advisable / good, which is usually the most interesting part of a change.

I write *why* description.

> 
> > LayoutTests/ChangeLog:8
> > +        Test that table-caption which stride over columns should be at the top of 2nd column.
> 
> I am not familiar with the term 'stride' nor does the meaning I found explain this sentence (nor the other ChangeLog FWIW) in any meaningful way. Care to reformulate?

Change a sentence.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.