[Webkit-unassigned] [Bug 109011] File upload control doesn't apply CSS vertical padding or border to file name

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109011





--- Comment #14 from Nils Barth <nbarth at chromium.org>  2013-02-12 01:40:15 PST ---
(In reply to comment #13)
> Created an attachment (id=187807)
 --> (https://bugs.webkit.org/attachment.cgi?id=187807&action=review) [details]
> Patch

One question and two note:
1. Naming convention for layout tests?

In directory: fast/forms/file
there are tests for the file input (<input type="file"/>) element
with both these name types:
  file-input-*
  input-file-*
It's roughly even, with a few more file-input-* so that's what I used,
but I can changed it -- which is preferred?


2. Bug 109104 is related

There is a separate problem with laying out/sizing/rendering the text when the button itself isn't rendered.

Bug 109102 hits this issue (in fact causing a crash), with the note that:
LayoutTests/fast/forms/file/display-none-upload-button.html
// FIXME: The text inside the file input should give the input a contentHeight
// even when there's no upload button.

This affects the same line (due to baseline/vertical spacing), but is a separate issue.

3. Bug causes incorrect layout too

This bug not only causes incorrect positioning of the file name, but also caused the vertical size of the element to be a bit off (too big if there is CSS padding), which can be seen in the layout tests. The patch fixes this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.