[Webkit-unassigned] [Bug 102453] Move SubimageCacheWithTimer to a separate file.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 00:46:20 PST 2013


--- Comment #9 from Benjamin Poulain <benjamin at webkit.org>  2013-02-12 00:48:33 PST ---
(From update of attachment 186934)
View in context: https://bugs.webkit.org/attachment.cgi?id=186934&action=review

I think it is misleading to have stuff like subimage(CGImageRef, const FloatRect&) in the new files. The new files should only contain the minimum for the definition and implementation of SubimageCacheWithTimer.

I would also promote SubimageCacheWithTimer to a real class with real encapsulation now that it is promoted from a tool to a header.

> Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.cpp:2
> + * Copyright (C) 2013 Apple Inc. All Rights Reserved.

You need to preserve the full original copyright too (or hunt who did the changes).

> Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.h:2
> + * Copyright (C) 2013 Apple Inc. All Rights Reserved.

Ditto for copyright.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list