[Webkit-unassigned] [Bug 105348] XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105348





--- Comment #12 from Allan Sandfeld Jensen <allan.jensen at digia.com>  2013-02-11 15:45:08 PST ---
(In reply to comment #11)
> > your patch also conflicts a little with comment below it:
> > // m_deferEvents is kept true until all deferred events have been dispatched.
> 
> I don't think that there is a conflict there. With this change, m_deferEvents is set to false only when there are no deferred events.
> 
> Note that this comment disagrees with what XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents() actually does. It sets m_deferEvents to false immediately, and even notes that there may be leftover events remaining in m_deferredEvents.
> 
> So I think that this patch is correct, however the code needs another look.

The point in this case is that m_deferEvents means that resume has been called, but dispatchDeferredEvents() has not. This is a half-resumed state that can be cancelled in case something else causes a suspend before dispatchDeferredEvents() has a chance to run.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.