[Webkit-unassigned] [Bug 105348] XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 15:26:32 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105348





--- Comment #11 from Alexey Proskuryakov <ap at webkit.org>  2013-02-11 15:28:44 PST ---
> your patch also conflicts a little with comment below it:
> // m_deferEvents is kept true until all deferred events have been dispatched.

I don't think that there is a conflict there. With this change, m_deferEvents is set to false only when there are no deferred events.

Note that this comment disagrees with what XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents() actually does. It sets m_deferEvents to false immediately, and even notes that there may be leftover events remaining in m_deferredEvents.

So I think that this patch is correct, however the code needs another look.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list