[Webkit-unassigned] [Bug 109305] [WK2] Page reloading will crash UIProcess after WebProcess was killed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109305





--- Comment #15 from Christophe Dumez <dchris at gmail.com>  2013-02-11 13:07:35 PST ---
(From update of attachment 187630)
View in context: https://bugs.webkit.org/attachment.cgi?id=187630&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:31
> +#include <stdio.h>

Is this really needed?

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:35
> +static bool done = false;

I think we only need one boolean.

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:40
> +    // Ok, this is the first load

iirc. Coding style says comments should end with a period.

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:43
> +        EXPECT_TRUE(done);

This check right after assigning does not seem useful.

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:48
> +    EXPECT_EQ(static_cast<uint32_t>(kWKFrameLoadStateFinished), WKFrameGetFrameLoadState(frame));

This check could be done in CrashReload test function.

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:50
> +    EXPECT_TRUE(loaded);

This check right after assigning does not seem useful.

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:60
> +    loaderClient.didFinishLoadForFrame = didFinishLoad;

Should we make sure processDidCrash is called as well?

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:67
> +    Util::sleep(3);

I don't understand why we need to sleep.

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:69
> +    Util::sleep(3);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKit2/CrashReload.cpp:70
> +    WKPageLoadURL(webView.page(), adoptWK(WKURLCreateWithUTF8CString("about:blank")).get());

Since we use the same WKUrl twice, maybe we could create it once and store it in a variable?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.