[Webkit-unassigned] [Bug 109284] Web Inspector: for event listener provide handler function value in protocol and in UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109284





--- Comment #5 from Peter Rybin <prybin at chromium.org>  2013-02-11 12:31:44 PST ---
> > Source/WebCore/bindings/v8/ScriptEventListener.cpp:112
> > +    V8AbstractEventListener* v8Listener = static_cast<V8AbstractEventListener*>(listener);
> Please extract common part with eventListenerHandlerBody into a separate function.

Cannot do this thing. It turned out that final toWebCoreStringWithNullCheck statement depends on contextScope and breaks if the object doesn't exist.

> > Source/WebCore/inspector/Inspector.json:1748
> > +                    { "name": "handler", "$ref": "Runtime.RemoteObject", "optional": true, "hidden": true, "description": "Event handler function value" }
> The type is already hidden.

Done

> > Source/WebCore/inspector/Inspector.json:1870
> > +                    { "name": "objectGroup", "type": "string", "optional": true, "description": "Symbolic group name for handler value." }
> Please add a note on that handler won't be returned if the group is not specified.

Done

> > Source/WebCore/inspector/InspectorDOMAgent.cpp:1394
> > +                InjectedScript injectedScript = m_injectedScriptManager->injectedScriptFor(mainWorldScriptState(frame));
> You should use the world from event listener instead.

Done

> > Source/WebCore/inspector/front-end/EventListenersSidebarPane.js:123
> > +            node.eventListeners("arabypaC", callback);
> Please use WebInspector.EventListenersSidebarPane._objectGroupName

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.