[Webkit-unassigned] [Bug 93214] [EFL][DRT] http/tests/loading/307-after-303-after-post.html times out

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93214





--- Comment #12 from Martin Robinson <mrobinson at webkit.org>  2013-02-11 10:01:56 PST ---
(From update of attachment 187594)
View in context: https://bugs.webkit.org/attachment.cgi?id=187594&action=review

Perhaps it makes sense to unskip this test on GTK+ as well?

> Source/WebCore/ChangeLog:5
> +        [EFL][DRT] Ensured that GET verb is used for requests
> +        triggered from a succession of 307 and other 3XX responses.
> +        https://bugs.webkit.org/show_bug.cgi?id=93214

The first line should be the bug title and then the description should go underneath.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:457
> -    ResourceRequest request = handle->firstRequest();
> +    ResourceRequest newRequest = handle->firstRequest();

I like this change a lot!

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:468
> +    if (shouldRedirectAsGET(message, newURL, crossOrigin) || newRequest.httpMethod() != message->method) {
> +        newRequest.setHTTPMethod("GET");
> +        newRequest.setHTTPBody(0);
> +        newRequest.clearHTTPContentType();
>      }

Hrm. Shouldn't this restore the original method instead of just unconditionally using GET? In any case, why not roll this into shouldRedirectAsGET?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.