[Webkit-unassigned] [Bug 93214] [EFL][DRT] http/tests/loading/307-after-303-after-post.html times out

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93214





--- Comment #11 from youenn fablet <youennf at gmail.com>  2013-02-11 09:09:26 PST ---
After reading the code again, I would tend to stick with the current approach.
Storing a modified ResourceRequest is deviating from other port strategies.
It may also take more work to keep in sync things (referer, auth..) between the hops than go from firstRequest to the latest hop.

In the newly submitted patch, shouldRedirectAsGET is not modified.
The check is directly added in doRedirect.
The check is a bit looser than in the previous patch but I hope it is fine as is.
I also renamed request in newRequest, in the hope it makes the code clearer.

In the same vein, there is some code that looks a bit suspicious in resourceHandleSoup.cpp/handleUnignoredTLSErrors.
The host name that is used to retrieve certificates (that are not CA validated but granted by user) is coming from firstRequest.
To properly handle redirections, it may be better to get it directly from the soup layer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.