[Webkit-unassigned] [Bug 109354] RenderText::isAllCollapsibleWhitespace() shouldn't upconvert string to 16-bit.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109354





--- Comment #5 from Darin Adler <darin at apple.com>  2013-02-11 07:40:48 PST ---
(From update of attachment 187429)
View in context: https://bugs.webkit.org/attachment.cgi?id=187429&action=review

>> Source/WebCore/rendering/RenderText.cpp:1193
>> +        if (!style()->isCollapsibleWhiteSpace(characterAt(i)))
> 
> I would store textLength() in a temporary variable.
> 
> You may want to split this in 2 cases, 8bits and 16bits, instead of doing that in the loop.

Ben has a good point about the two cases. The new code is going to be considerably slower than two separate loops. You could prove we need only a single loop with performance testing, or you could write the two loops.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.