[Webkit-unassigned] [Bug 109297] [chromium] clean-up use of auto_ptr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109297





--- Comment #3 from Tony Chang <tony at chromium.org>  2013-02-08 11:05:09 PST ---
(In reply to comment #2)
> chromium's public WebKit API already depends on base, e.g. WebString includes <base/string16> (and GURL, WebURL includes gurl.h)

gurl.h is part of googleurl, not base.  base/string16.h is a layering violation, but perhaps we thought it was OK since it's not likely to change.  It's also important that the WebString string16 is the same as string16 in chromium.

> Of couse, we could copy the few files required, but I don't really see the point as there's no new dependency

I think we should still try to avoid adding dependencies to more files in base if they're easy to avoid.  scoped_ptr.h seems to undergo frequent changes. I don't want to slow that down with this dependency.  It would be easy to make a simplified scoped_ptr.h for use by DRT.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.