[Webkit-unassigned] [Bug 109268] [v8] isolate parameter added to all v8::peristent calls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 00:44:06 PST 2013


--- Comment #5 from Dan Carney <dcarney at google.com>  2013-02-08 00:46:14 PST ---
(From update of attachment 187256)
View in context: https://bugs.webkit.org/attachment.cgi?id=187256&action=review

>> Source/WebCore/bindings/v8/NPV8Object.cpp:95
>> +    v8NpObject->v8Object.Dispose(v8::Isolate::GetCurrent());
> Can we avoid calling Isolate::GetCurrent() by passing an Isolate around?

All np stuff is on the main isolate. I'm going to add a static variable for the main world isolate, which is why I don't want to pass parameters around here. Again, no need for zillions of fixmes here either

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list