[Webkit-unassigned] [Bug 108899] Coordinated Graphics : Refactor CoordinatedSurface to prepare for WebKit1 CoordinatedSurface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108899





--- Comment #4 from Jae Hyun Park <jae.park at company100.net>  2013-02-07 18:47:54 PST ---
(In reply to comment #3)
> This part doesn't make sense to me; Why not, instead, use explicit beginPaint that returns GraphicsContext* and endPaint?
> We should find a more readable solution than the "holder" pattern...

Thanks for the review!

In the current implementation, CoordinatedTile::updateBackBuffer() releases the PassOwnPtr<GraphicsContext> after using it.

IMHO, if we want to use beginPaint and endPaint pattern, we need to know CoordinatedSurface in CoordinatedTile, which is not pretty.
If we add a method such as UpdateAtlas::endPaintingOnAvailableBuffer, which will call endPaint in CoordinatedSurface, we still need to pass around UpdateAtlas.

I'm not sure which way is the right way to go. I'd really appreciate your comment noam :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.