[Webkit-unassigned] [Bug 109037] [GTK][AC] Clutter required version up to 1.12

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109037





--- Comment #3 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2013-02-07 11:05:01 PST ---
(From update of attachment 186812)
View in context: https://bugs.webkit.org/attachment.cgi?id=186812&action=review

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:218
>> +            return;
> 
> This is a change in behaviour, right? Would be good to separate "bringing stuff up-to-date" with behaviour changes.

Right, let me open a new bug to handle this kind of stuff.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:396
>> +    graphicsLayerActorSetAnchorPoint(m_layer.get(), m_anchorPoint.x(), m_anchorPoint.y(), m_anchorPoint.z());
> 
> Ditto. You're now ignoring the calculations done for adjusted*(), that might be OK (I think it might break AC on zoomed pages, though, did you check it doesn't?), but should be its own change.

O.K. Let's deal with this in an another bug. Current implementations doesn't support page scaling, too.
I think using adjusted* values is wrong here for clutterActor position. Actually, clutter coordinate system doesn't need to recalculate ajusted* value because it has a different coordinate system over mac port. Basically, the position of a CALayer(?) is specified in terms of the location of the layer's anchorPoint in mac port, so mac port need to recalculate the layer position after changing anchor position. See https://developer.apple.com/library/ios/#documentation/Cocoa/Conceptual/CoreAnimation_guide/CoreAnimationBasics/CoreAnimationBasics.html#//apple_ref/doc/uid/TP40004514-CH2-SW15

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.