[Webkit-unassigned] [Bug 108899] Coordinated Graphics : Refactor CoordinatedSurface to prepare for WebKit1 CoordinatedSurface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108899


Noam Rosenthal <noam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #186539|review?                     |review-
               Flag|                            |




--- Comment #3 from Noam Rosenthal <noam at webkit.org>  2013-02-06 23:38:46 PST ---
(From update of attachment 186539)
View in context: https://bugs.webkit.org/attachment.cgi?id=186539&action=review

> Source/WebCore/ChangeLog:20
> +        1. It introduces CoordinatedGraphics::GraphicsContextHolder. Other
> +        classes access GraphicsContext via GraphicsContextHolder, instead of
> +        accessing GraphicsContext directly.
> +
> +        WebKit1 CoordinatedSurface will be implemented using GraphicsSurface and
> +        ImageBuffer. ImageBuffer owns GraphicsContext itself and cannot pass its
> +        OwnPtr. Therefore, this patch refactors CoordinatedSurface to pass
> +        GraphicsContextHolder, and make other classes access GraphicsContext via
> +        GraphicsContextHolder.

This part doesn't make sense to me; Why not, instead, use explicit beginPaint that returns GraphicsContext* and endPaint?
We should find a more readable solution than the "holder" pattern...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.