[Webkit-unassigned] [Bug 109061] <link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 17:14:02 PST 2013


--- Comment #8 from Brady Eidson <beidson at apple.com>  2013-02-06 17:16:09 PST ---
Good point, but...

There is a comment inside Document::ironURLs() that says:
// Include any icons where type = link, rel = "shortcut icon".

Admittedly this is an example of why comments aren't good enforcement over more obvious naming in code.  But that point aside, this patch changes that behavior.

This method is about "shortcut icons" that should be considered in the course of normal favicon loading whereas apple-touch-icons were always meant to be loaded out of band from normal page loading.

We should rename iconURLs to shortcutIconURLs and leave it's behavior as-is.  If you need to get at the apple-touch-icons for whatever reason, they can be in a different accessor.

You could also refactor the current accessor to take an IconType parameter and leverage that for code reuse between the current behavior and the new behavior you hope to add.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list