[Webkit-unassigned] [Bug 102656] The 2D Canvas functions fillText()/strokeText() should display nothing when maxWidth is less then or equal to zero

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 15:36:20 PST 2013


--- Comment #12 from Dirk Schulze <krit at webkit.org>  2013-02-06 15:38:26 PST ---
(From update of attachment 186827)
View in context: https://bugs.webkit.org/attachment.cgi?id=186827&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2176
> +    if (useMaxWidth && ( !isfinite(maxWidth) || (maxWidth <= 0) ))

Remove the spaces between ( and ! as well as the last space. The braces around maxWidth <= 0  seem to be unnecessary too.

Did you test that on Firefox, Opera and IE as well? Do they not draw the text? If they do, we should keep it the same way.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list