[Webkit-unassigned] [Bug 107829] Web Inspector: support JavaScript variable mutation in protocol and V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107829





--- Comment #18 from Peter Rybin <prybin at chromium.org>  2013-02-06 14:49:30 PST ---
> Mac EWS claims inspector-protocol/debugger-setVariableValue.html [ Failure ] is failing. Otherwise looks good.
Fixed

> > Source/WebCore/bindings/v8/DebuggerScript.js:99
> > +    if (!mirror.isFunction()) {
> no {} around single line blocks.
Done

> > Source/WebCore/bindings/v8/DebuggerScript.js:108
> > +    if (!scopeMirror) {
> ditto
Done

> > Source/WebCore/bindings/v8/JavaScriptCallFrame.cpp:142
> > +        deprecatedV8String(variableName),
> What is deprecatedV8String ?
I copy-pasted code that was under multi-step refactoring.

> > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:602
> > +    String newValueStr = newValue->toJSONString();
> netValueString (no abbreviations in WebKit). Why don't you pass it as RefPtr?
Renamed. I did like similar command callFunctionOn is implemented.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.