[Webkit-unassigned] [Bug 108961] [GTK][AC] Implement opacity animation with clutter ac backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108961





--- Comment #4 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2013-02-06 08:20:37 PST ---
(From update of attachment 186675)
View in context: https://bugs.webkit.org/attachment.cgi?id=186675&action=review

Thanks! :D

>> Source/WebCore/ChangeLog:9
>> +        Almost implementations of GraphicsLayerClutter are based on mac port's one.
> 
> This sentence seems to be missing a word. "Almost all"?

Oops. Sorry.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:32
>> +#include <wtf/text/CString.h>
> 
> No blank line.

Done

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:45
>> +#include <limits.h>
> 
> Ditto.

yeap.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:53
>> +// If we send a duration of 0 to CA, then it will use the default duration
> 
> Talking about CA here doesn't make much sense =)

Updated the comment talking about clutterTimeline.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:678
>> +    // CoreAnimation does not handle the steps() timing function. Fall back
> 
> Another CA-related comment here.

I rewrote this comment.

>> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:398
>> +        notImplemented();
> 
> Make these ASSERT_NOT_REACHED() for now? You should be refusing to create these kinds of animations, so they should really not be reached.

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.