[Webkit-unassigned] [Bug 109011] File upload control doesn't apply CSS vertical padding or border to file name
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 5 23:48:09 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=109011
Kent Tamura <tkent at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #186769|review? |review-
Flag| |
--- Comment #2 from Kent Tamura <tkent at chromium.org> 2013-02-05 23:50:15 PST ---
(From update of attachment 186769)
View in context: https://bugs.webkit.org/attachment.cgi?id=186769&action=review
We need a test.
I think we can't make a dumpAsText test for this change. Probably we need a ref test.
> Source/WebCore/rendering/RenderFileUploadControl.cpp:142
> + LayoutUnit textY = paintOffset.y() + borderLeft() + paddingLeft() + buttonRenderer->baselinePosition(AlphabeticBaseline, true, HorizontalLine, PositionOnContainingLine);
Why do you add border-left and padding-left to the vertical position?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list