[Webkit-unassigned] [Bug 108983] webkit-patch upload regenerates the WebCore ChangeLog every time it's called

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 23:14:37 PST 2013


--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2013-02-05 23:16:44 PST ---
(In reply to comment #3)
> The main point of the feature is to add to the change log entry new touched files/functions. At the moment there's really no way to tell the difference between what's been just added, or what's been removed.

That's why I'm suggesting to make this an opt-in feature. It's annoying for a tool to enforce a particular change when that change is not necessarily desirable.

>The way I see it is that adding functionality to see what the user has removed is unnecessary since the simplest solution is to just leave in the lines like (WebCore) in the change log entries (which I think most people would be doing anyway), which makes this is a non-issue.

That's not an option. The reason a developer deletes such an entry is because it's incorrect or unnecessary.

> Another option is to revert to the previous behaviour (i.e. don't update the change logs with the new list) by default, and have the new behaviour behind a flag, but I'm not sure that this would be preferred by other developers.

I think that's a much better behavior. The the patch made webkit-patch useless in many situations until we added --no-prepare-changelogs.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list