[Webkit-unassigned] [Bug 108983] webkit-patch upload regenerates the WebCore ChangeLog every time it's called

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 23:09:45 PST 2013


--- Comment #3 from Timothy Loh <timloh at chromium.org>  2013-02-05 23:11:51 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > Did you manually remove "(WebCore):" and "(RenderBox):" from the list, because if so, this is *technically* a feature (albeit an annoying one), and we can work out some heuristics to allow this behaviour to pass (maybe allow users to delete (\w*): from .cpp and .h files).
> I would have preferred for features like this one to run only when developers told the tool to do so. Automatically adding things back into change log seems overly aggressive.

The main point of the feature is to add to the change log entry new touched files/functions. At the moment there's really no way to tell the difference between what's been just added, or what's been removed. The way I see it is that adding functionality to see what the user has removed is unnecessary since the simplest solution is to just leave in the lines like (WebCore) in the change log entries (which I think most people would be doing anyway), which makes this is a non-issue.

Another option is to revert to the previous behaviour (i.e. don't update the change logs with the new list) by default, and have the new behaviour behind a flag, but I'm not sure that this would be preferred by other developers.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list