[Webkit-unassigned] [Bug 108132] Refactor the way HAVE_XXX macros are set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108132


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185130|review?                     |review-
               Flag|                            |




--- Comment #3 from Benjamin Poulain <benjamin at webkit.org>  2013-02-05 14:10:58 PST ---
(From update of attachment 185130)
View in context: https://bugs.webkit.org/attachment.cgi?id=185130&action=review

Unless I missed a HAVE_DISPATCH_H, this is gonna break iOS.

> Source/WTF/wtf/Platform.h:725
> -#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060
> -
> +#if OS(DARWIN) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060
>  #define HAVE_DISPATCH_H 1
>  #define HAVE_HOSTED_CORE_ANIMATION 1

This will break iOS.

Do we still need __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060 actually?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.