[Webkit-unassigned] [Bug 100261] [gtk] core implementation for getUserMedia API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100261





--- Comment #17 from Philippe Normand <pnormand at igalia.com>  2013-02-05 08:55:39 PST ---
(In reply to comment #16)
> (In reply to comment #15)
> > Looks good overall, the Stream player seems quite incomplete though, I wonder if it'd make sense to have only the refactoring in this patch and keep a minimal-working stream player for a separate patch?
> 
> Yeah, I was debating that as well.  I can do that if you'd like.
> 

Yes please!

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:110
> > > +    GRefPtr<GstStreamVolume> m_volume;
> > 
> > This name could be confusing, what about m_volumeElement? Also, OOC don't we need a GRefPtr specific implementation for GstStreamVolume, which is an interface, I'm not sure how it combines with GRefPtr in this patch.
> 
> Well, since there's no template specialization for GstStreamVolume, it should just use the un-specialized implementation (GRefPtr<T>), which is the implementation for GObject (g_object_ref_sink/g_object_unref).  Since GstStreamVolume has 'GObject' as its only prerequisite, this is probably correct behavior, right?
> 

Ah right indeed. Thanks for clarifying :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.