[Webkit-unassigned] [Bug 107840] Add smartInsertDeleteEnabled setting to WebCore::Page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107840





--- Comment #17 from Manuel Rego Casasnovas <rego at igalia.com>  2013-02-05 00:59:41 PST ---
(In reply to comment #16)
> (From update of attachment 185048 [details])
> Looks like this breaks initial value of the setting on Mac. We used to get it from "WebSmartInsertDeleteEnabled" user default in TextChecker::isSmartInsertDeleteEnabled(), and pass on process creation. Now, looks like every client has to call WKPreferencesSetSmartInsertDeleteEnabled().
> 
> Even worse, if WKPreferencesSetSmartInsertDeleteEnabled() gets called by the client, it is a no-op because of an early return:
> 
> void WebPageProxy::setSmartInsertDeleteEnabled(bool isSmartInsertDeleteEnabled)
> {
>     if (m_isSmartInsertDeleteEnabled == isSmartInsertDeleteEnabled)
>         return;
> 
> So, this means that WKPreferencesSetSmartInsertDeleteEnabled(false) will have no effect on Mac if WebSmartInsertDeleteEnabled was set to NO.

Yes, you're right thanks for pointing it out. The problem is that in my patch I'm removing isSmartInsertDeleteEnabled from page creation parameters, so the initial value on Mac is lost as you say.

I'm going to attach a new patch with a small change in order to set the new setting in WebPageProxy::initializeWebPage using the initial value from TextChecker::isSmartInsertDeleteEnabled().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.